Also set up signals for legacy push support#9429
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for legacy notify_push versions (< 0.4.0) by connecting to both the filesChanged signal (legacy, no file IDs) and the fileIdsChanged signal (new, with specific file IDs) from the PushNotifications class. The PR splits the original slotReceivedPushFileChanges handler into two separate handlers to accommodate both signal types.
Changes:
- Split file change notification handling into two methods: legacy handler for generic file changes and modern handler for file ID-specific changes
- Added signal connections/disconnections for both legacy and modern push notification signals
- Updated File Provider integration to handle both notification types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/gui/tray/usermodel.h | Added two new slot declarations replacing the single original slot: slotReceivedPushFilesChanges (legacy) and slotReceivedPushFileIdsChanges (modern) |
| src/gui/tray/usermodel.cpp | Implemented both new handlers, updated signal connections/disconnections, and forwarded notifications to File Provider Domain Manager |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1f288d0 to
e664974
Compare
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
e664974 to
c442e55
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Artifact containing the AppImage: nextcloud-appimage-pr-9429.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|




Closes #9428.