Skip to content

Also set up signals for legacy push support#9429

Merged
i2h3 merged 1 commit intomasterfrom
i2h3/fix/9428-legacy-push-support
Feb 6, 2026
Merged

Also set up signals for legacy push support#9429
i2h3 merged 1 commit intomasterfrom
i2h3/fix/9428-legacy-push-support

Conversation

@i2h3
Copy link
Copy Markdown
Collaborator

@i2h3 i2h3 commented Feb 6, 2026

Closes #9428.

@i2h3 i2h3 added this to the 33.0.0 milestone Feb 6, 2026
@i2h3 i2h3 self-assigned this Feb 6, 2026
@i2h3 i2h3 requested a review from Aiiaiiio as a code owner February 6, 2026 08:59
Copilot AI review requested due to automatic review settings February 6, 2026 08:59
@i2h3 i2h3 requested a review from camilasan as a code owner February 6, 2026 08:59
@i2h3 i2h3 added the feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system. label Feb 6, 2026
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Feb 6, 2026
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Feb 6, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for legacy notify_push versions (< 0.4.0) by connecting to both the filesChanged signal (legacy, no file IDs) and the fileIdsChanged signal (new, with specific file IDs) from the PushNotifications class. The PR splits the original slotReceivedPushFileChanges handler into two separate handlers to accommodate both signal types.

Changes:

  • Split file change notification handling into two methods: legacy handler for generic file changes and modern handler for file ID-specific changes
  • Added signal connections/disconnections for both legacy and modern push notification signals
  • Updated File Provider integration to handle both notification types

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/gui/tray/usermodel.h Added two new slot declarations replacing the single original slot: slotReceivedPushFilesChanges (legacy) and slotReceivedPushFileIdsChanges (modern)
src/gui/tray/usermodel.cpp Implemented both new handlers, updated signal connections/disconnections, and forwarded notifications to File Provider Domain Manager

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@i2h3 i2h3 force-pushed the i2h3/fix/9428-legacy-push-support branch from 1f288d0 to e664974 Compare February 6, 2026 09:14
@i2h3 i2h3 requested a review from Copilot February 6, 2026 09:14
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
@i2h3 i2h3 force-pushed the i2h3/fix/9428-legacy-push-support branch from e664974 to c442e55 Compare February 6, 2026 09:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9429.zip

Digest: sha256:7602c393c928847b1fd329bc58eca98fc7ed37117d4c190e177fb96dd2acf9df

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Copy Markdown
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
Image 1 Security Hotspot
Image 0.0% Coverage on New Code (required ≥ 80%)
Image D Maintainability Rating on New Code (required ≥ A)
Image 35 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@i2h3 i2h3 merged commit 82679a5 into master Feb 6, 2026
27 of 35 checks passed
@i2h3 i2h3 deleted the i2h3/fix/9428-legacy-push-support branch February 6, 2026 12:26
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: 📁 file provider macOS File Provider Extension, more general also known as virtual file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notify_push Legacy Support

4 participants