bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy build bots.#19544
Merged
jaraco merged 3 commits intopython:masterfrom Apr 15, 2020
jaraco:bugfix/35967-more-lenient-test
Merged
bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy build bots.#19544jaraco merged 3 commits intopython:masterfrom jaraco:bugfix/35967-more-lenient-test
jaraco merged 3 commits intopython:masterfrom
jaraco:bugfix/35967-more-lenient-test
Conversation
aeros
reviewed
Apr 15, 2020
Contributor
aeros
left a comment
There was a problem hiding this comment.
Thanks for the PR @jaraco. I would suggest updating the title of the PR to refer to the specific test being changed, e.g. Make test_platform.test_uname_processor .... I also have a couple of minor suggestions regarding the test itself.
Contributor
|
Also, I didn't look through all of the buildbot failures, but my results above are consistent with the raspbian failure: |
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
Member
Author
TIL |
Member
Author
|
It seems to me the remaining buildbot failures were due to spurious failures unrelated to this change, so I'm pretty sure this change works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GH-12824, I added a test to capture the status quo expectation of
platform.uname.processor. Then sir bedevere informed me that the buildbots are failing. This patch is intended to address that failure.https://bugs.python.org/issue35967