Skip to content

bpo-43059: sqlite3: Remove reference to legacy external sqlite3 repository#24364

Merged
berkerpeksag merged 1 commit intopython:masterfrom
LukeLR:master
Jan 31, 2021
Merged

bpo-43059: sqlite3: Remove reference to legacy external sqlite3 repository#24364
berkerpeksag merged 1 commit intopython:masterfrom
LukeLR:master

Conversation

@LukeLR
Copy link
Contributor

@LukeLR LukeLR commented Jan 28, 2021 •
edited by bedevere-bot
Loading

As discussed in issue43059, the link to the external sqlite3 repository is probably obsolete and can be removed.

https://bugs.python.org/issue43059

@LukeLR LukeLR requested a review from berkerpeksag as a code owner January 28, 2021 21:36
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jan 28, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@LukeLR

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 28, 2021
berkerpeksag
berkerpeksag approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berkerpeksag berkerpeksag merged commit e603443 into python:master Jan 31, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jan 31, 2021

Thanks @LukeLR for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2021
@LukeLR @miss-islington
bpo-43059: Remove reference to legacy external sqlite3 repository (py…
ec97958 
…thonGH-24364)

(cherry picked from commit e603443)

Co-authored-by: L <3177243+LukeLR@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 31, 2021

GH-24392 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2021
@LukeLR @miss-islington
bpo-43059: Remove reference to legacy external sqlite3 repository (py…
6dbca97 
…thonGH-24364)

(cherry picked from commit e603443)

Co-authored-by: L <3177243+LukeLR@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 31, 2021

GH-24393 is a backport of this pull request to the 3.8 branch.

berkerpeksag pushed a commit that referenced this pull request Jan 31, 2021
@miss-islington @LukeLR
bpo-43059: Remove reference to legacy external sqlite3 repository (GH…
926ca51 
…-24364)

(cherry picked from commit e603443)

Co-authored-by: L <3177243+LukeLR@users.noreply.github.com>
berkerpeksag pushed a commit that referenced this pull request Jan 31, 2021
@miss-islington @LukeLR
bpo-43059: Remove reference to legacy external sqlite3 repository (GH…
de76ce5 
…-24364)

(cherry picked from commit e603443)

Co-authored-by: L <3177243+LukeLR@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@LukeLR @adorilson
bpo-43059: Remove reference to legacy external sqlite3 repository (py…
35d5647 
…thonGH-24364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LukeLR @the-knights-who-say-ni @miss-islington @bedevere-bot @berkerpeksag @erlend-aasland @merwok