bpo-43083: Fix error handling in _sqlite3#24395
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Jan 31, 2021
Merged
bpo-43083: Fix error handling in _sqlite3#24395serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
serhiy-storchaka
added
type-bug
Member
Author
|
No NEWS entry is needed because it is very difficult (if possible) to reproduce these bugs, and it is very difficult to explain the fix to average Python user without referring to internal implementation details. |
berkerpeksag
approved these changes
Jan 31, 2021
Member
berkerpeksag
left a comment
berkerpeksag
left a comment
There was a problem hiding this comment.
LGTM! Not sure about backporting to 3.8 and 3.9, though. 3.9 may make sense to make future auto-backports a bit easier, but I'd probably leave 3.8 alone.
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 31, 2021
(cherry picked from commit 9073180) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-24400 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 31, 2021
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43083