bpo-32436: Don't use native popcount() (also fixes bpo-32641)#5292
Merged
1st1 merged 1 commit intopython:masterfrom Jan 24, 2018
Merged
bpo-32436: Don't use native popcount() (also fixes bpo-32641)#52921st1 merged 1 commit intopython:masterfrom
1st1 merged 1 commit intopython:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSE 4.2 is pretty recent is there's plenty of hardware out there that doesn't support it. To minimize the risk of CPython build not running on older CPUs it's easier to just stop using the
popcntinstruction.I used the following micro-benchmark to make a decision to drop native popcount and always use the portable fallback code:
The results were the same on both with/without popcount builds.
To test the popcount instruction I've compiled CPython with `CFLAGS="-march=native". lldb session:
https://bugs.python.org/issue32436