Merged
Conversation
Contributor
smacker
commented
Feb 28, 2018
smacker
commented
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>
Contributor
|
@smacker Looks solid. I would just remove border-radius & shadow from the element, but it's not mandatory for now. |
bzz
approved these changes
Feb 28, 2018
Contributor
bzz
left a comment
bzz
left a comment
There was a problem hiding this comment.
LGTM
and 👍 for nice refactoring.
dpordomingo
approved these changes
Feb 28, 2018
Contributor
dpordomingo
left a comment
dpordomingo
left a comment
There was a problem hiding this comment.
LGTM
many thanks for this new shortcut !!
If it's easy for you to do it, please address @ricardobaeta suggestion, and if it's not let's merge now and add his suggestion to our UI todo list
(it would be nice to have a list of UI things to improve; I'm not sure if we already have it)
Contributor
Author
|
This PR adding one more item in menu. It doesn't change UI. Issue for ui: #179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
