Merged
Conversation
rporres
force-pushed
the
ci-cd-travis
branch
3 times, most recently
from
eabfae3 to
9e85e14
Compare
Signed-off-by: Rafael Porres Molina <rafa@sourced.tech>
Author
|
Deployed in staging correctly https://code-annotation-staging.srcd.run/, although I don't have permissions to further test anything cc @src-d/applications |
Co-Authored-By: David Pordomingo <david.pordomingo.f@gmail.com>
dpordomingo
reviewed
Oct 8, 2019
Contributor
dpordomingo
left a comment
dpordomingo
left a comment
There was a problem hiding this comment.
LGTM.
We developed this long time ago, it was a kind of wip and staled more than a year ago, so my level of confidence in this review is 7/10.
Checks I did:
- deploy is done following the same steps in Travis than in former Drone,
- deploy in Staging works, and data is kept between deploys, and the server https://code-annotation-staging.srcd.run is also accessible and running.
- confirmed with Infra that we have snapshots of current production database, and a way to rollback.
I'd recommend:
- merge,
- tag -> deploy
- perform a sanity check to ensure the data is there -> and forget this issue 🤞
dpordomingo
approved these changes
Oct 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafael Porres Molina rafa@sourced.tech