Skip to content

Add gorilla dependency#43

Merged
smacker merged 1 commit intosrc-d:masterfrom
dpordomingo:add-gorilla-dependencies
Jan 30, 2018
Merged

Add gorilla dependency#43
smacker merged 1 commit intosrc-d:masterfrom
dpordomingo:add-gorilla-dependencies

Conversation

@dpordomingo
Copy link
Copy Markdown
Contributor

@dpordomingo dpordomingo commented Jan 29, 2018

blocks #37

ptal @src-d/applications

Add gorilla dependency as already required by ./server/service/oauth.go

@dpordomingo dpordomingo changed the title Add gorilla dependency as already required by ./server/service/oauth.go Add gorilla dependency Jan 29, 2018
This was referenced Jan 29, 2018
Copy link
Copy Markdown
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it is not part of #37 but LGMT.

Let's merge both asap.

@smacker smacker merged commit 4b4c4c6 into src-d:master Jan 30, 2018
@dpordomingo
Copy link
Copy Markdown
Contributor Author

@bzz it was not added in that PR because gorilla dependency was not introduced by that one

@dpordomingo dpordomingo deleted the add-gorilla-dependencies branch January 30, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants