Skip to content

Add the tree shaking RFC#20

Merged
matthewp merged 3 commits intomasterfrom
tree-shaking
Apr 20, 2018
Merged

Add the tree shaking RFC#20
matthewp merged 3 commits intomasterfrom
tree-shaking

Conversation

@matthewp
Copy link
Copy Markdown
Member

@matthewp matthewp commented Nov 29, 2017

Per feedback, this adds an example and goes through each step to remove
unused exports.
@frank-dspeed
Copy link
Copy Markdown

frank-dspeed commented Dec 1, 2017

@matthewp i see a other problem not handled what if i plan to use dynmaic something that i expect exportet?
For example i require underscore and later some function in my consumer code wants to use that dynamic and expects that all methods are use able? we need a tree shake ignore formart for the package.json glob or object based is the question if we would supply path info somehow like in my tar example we could go with glob i think else we need to solve that on package name?

@matthewp matthewp self-assigned this Dec 1, 2017
@matthewp
Copy link
Copy Markdown
Member Author

matthewp commented Apr 2, 2018

@frank-dspeed If a module is dynamically imported then it should not be tree shaken. I'll update the RFC with that information.

@matthewp
Copy link
Copy Markdown
Member Author

matthewp commented Apr 2, 2018

This RFC is entering final comment period. It will be merged in 7 days.

@matthewp matthewp mentioned this pull request Apr 2, 2018
3 tasks
@matthewp
Copy link
Copy Markdown
Member Author

matthewp commented Apr 20, 2018

Waited too long, this is being merged 🎸

@matthewp matthewp merged commit 34f74ba into master Apr 20, 2018
@matthewp matthewp deleted the tree-shaking branch April 20, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants