Merged
Conversation
3 tasks
Per feedback, this adds an example and goes through each step to remove unused exports.
|
@matthewp i see a other problem not handled what if i plan to use dynmaic something that i expect exportet? |
Member
Author
|
@frank-dspeed If a module is dynamically imported then it should not be tree shaken. I'll update the RFC with that information. |
Member
Author
|
This RFC is entering final comment period. It will be merged in 7 days. |
3 tasks
Member
Author
|
Waited too long, this is being merged 🎸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered