-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Add transitionary support for FB_BASEURL to FB_BASE_URL #3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #3049
Adapt new change from upstream changeset filebrowser/filebrowser@984ea7b
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Add transitional support for FB_BASEURL to FB_BASE_URL environment variable
Set both old and new environment variable names for backward compatibility
Update documentation to reference FileBrowser changelog for supported variables
Diagram Walkthrough
File Walkthrough
file-browser-deployment.yaml
Add FB_BASE_URL environment variable for backward compatibilitycharts/selenium-grid/templates/video-manager/file-browser-deployment.yaml
FB_BASE_URLenvironment variable alongside existingFB_BASEURLtransition
name
values.yaml
Update documentation with FileBrowser reference linkcharts/selenium-grid/values.yaml
extraEnvironmentVariablesto reference FileBrowserchangelog
variables
CONFIGURATION.md
Update configuration documentation with FileBrowser referencecharts/selenium-grid/CONFIGURATION.md
videoManager.extraEnvironmentVariablesvariables