Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Feb 14, 2025

oops, thanks to @neilcsmith-net for noticing this. Luckily this doesn't seem to affect the release artifact due to the nature of this module.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added the Code cleanup Label for cleanup done on the Netbeans IDE label Feb 14, 2025
@mbien mbien added this to the NB26 milestone Feb 14, 2025
@mbien mbien requested a review from neilcsmith-net February 14, 2025 21:56
@ebarboni
Copy link
Contributor

LGTM

but why was the missing license not detected ?

@neilcsmith-net
Copy link
Member

@ebarboni it only showed up with ant verify-all-libs-and-licenses (note all, not ant verify-libs-and-licenses). Also, the license is in there because there's an overlap with the file at https://github.com/apache/netbeans/blob/master/platform/o.n.bootstrap/external/launcher-external-binaries-2-6c17cc6-license.txt and one other. So the reference isn't missing, and it's our license anyway - no release issues with this one.

Copy link
Member

@neilcsmith-net neilcsmith-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbien

@mbien mbien merged commit f5846de into apache:master Feb 18, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code cleanup Label for cleanup done on the Netbeans IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants