Skip to content

Conversation

@NicolaIsotta
Copy link
Contributor

@NicolaIsotta NicolaIsotta commented Apr 16, 2025

Add new namespaces support.

For reference:
primefaces/primefaces#11923
primefaces/primefaces#11914
primefaces-extensions/primefaces-extensions#1548

With the PR, primefaces 15 (supports both the old http://primefaces.org/ui and the new primefaces namespace, see the "Library" line):
image

With the PR, primefaces 13 (supports only http://primefaces.org/ui)
image

@mbien mbien added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job labels Apr 16, 2025
@mbien mbien added this to the NB27 milestone Apr 16, 2025
@apache apache locked and limited conversation to collaborators Apr 16, 2025
@apache apache unlocked this conversation Apr 16, 2025
@mbien
Copy link
Member

mbien commented Apr 16, 2025

@NicolaIsotta thanks for updating this. I assume you tested it and it worked as expected?

@NicolaIsotta
Copy link
Contributor Author

NicolaIsotta commented Apr 16, 2025

Yes. But I found an improvement I can make, I'll mark this as draft meanwhile.

@NicolaIsotta NicolaIsotta marked this pull request as draft April 16, 2025 14:33
@NicolaIsotta NicolaIsotta force-pushed the pf-ns branch 2 times, most recently from 5e6e2c0 to 0907635 Compare April 16, 2025 16:10
@NicolaIsotta
Copy link
Contributor Author

NicolaIsotta commented Apr 16, 2025

Current behavior with NB 25 and primefaces 15:
image

@NicolaIsotta
Copy link
Contributor Author

With the PR, primefaces 15:
image

@NicolaIsotta
Copy link
Contributor Author

With the PR, primefaces 13 (which doesn't support the new namespace):
image

@NicolaIsotta NicolaIsotta marked this pull request as ready for review April 16, 2025 16:16
@NicolaIsotta NicolaIsotta changed the title add new PrimeFaces and PrimeFaces extensions namespaces add new PrimeFaces and OmniFaces namespaces Apr 21, 2025
@NicolaIsotta
Copy link
Contributor Author

I added OmniFaces too, it has a URN taglib starting from version 5:
https://balusc.omnifaces.org/2024/11/omnifaces-50-m1-46-3147-2727-have-been.html

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. I played a tiny bit with this and behavior seems to be sane.

@matthiasblaesing
Copy link
Contributor

@NicolaIsotta thank you for your contribution. I updated the PR description with the images from the later comments.

@matthiasblaesing matthiasblaesing merged commit c22dbac into apache:master May 12, 2025
31 checks passed
@mbien
Copy link
Member

mbien commented May 13, 2025

@NicolaIsotta congrats on your first contribution btw!

@NicolaIsotta NicolaIsotta deleted the pf-ns branch May 13, 2025 11:10
@LouisCollet
Copy link

Thanks for your efforts !
Quoting BalusC : you have during OmniFaces 5.x the opportunity to migrate the older XML namespaces xmlns:o="http://omnifaces.org/tags"
and xmlns:of="http://omnifaces.org/functions" to the single new XML namespace xmlns:o="omnifaces".
Yes, the both old namespaces of OmniFaces tags and EL functions have been merged into a single namespace for sake of simplicity.
I have tested it, but I still need the xmlns:of=http://omnifaces.org/functions if I use a function in my view .
Kind regards !
Louis

@NicolaIsotta
Copy link
Contributor Author

There's no need to add omnifaces functions namespace, it already works out-of-the-box in netbeans 26:
image

@LouisCollet
Copy link

LouisCollet commented Jul 29, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants