ComputeOverrides: move ClasspathInfo creation out of inner loops #8481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
lahodaj
approved these changes
May 22, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me - thanks!
Member
Author
|
thanks for the review! going to rebase before merge |
- jdk 17 code improvements and cleanup - deprecation fixes
- ClassIndex creation is expensive, ClasspahInfo initializes it lazily - this moves ClasspahInfo out of inner loops to reduce creation overhead of ClasspahInfo and its internal ClassIndex instance
mbien
force-pushed
the
compute-overrides-performance
branch
from
691e6ca to
bf86047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves the performance of the phase in which the overrides editor annotations are computed (similar to #8437 but no cache is needed here).
691e6ca has the perf enhancement
93dcd63 JDK 17 lang level cleanup in the containing
java.editor.overriddenpackageClassIndexcreation is expensive,ClasspahInfoinitializes it lazilyClasspahInfoout of inner loops to reduce creation overhead ofClasspahInfoand its internalClassIndexinstancerunning a synthetic test file with 10k package private elements
before:
after:
before:
after:
another hotspot with great potential for improvements is
ElementUtils#getTypeElementByBinaryName, but this has to be addressed separately.