update TextMark/Markdown tooling #8490
Conversation
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. I left an inline comment you might want to consider.
For the formal parts:
- In commits please ensure there is a first summary line, followed by an empty line. Then the details of the commit should follow, if they add info.
- The failing "PR Label" check is invalid here, as the
ide/textmate.lexertests are run always as part of the IDE cluster.
mbien
changed the title
|
was hoping this would fix the big block of warnings in the startup log (and also repeated during tests) but they are still there: Detailsnot completely sure when this started, but its in NB 25 and 26. |
|
@mbien my understanding is, that these warnings come from the textmate grammars, when the corresponding grammars are not present. Have a look at the |
@mbien , @matthiasblaesing is correct in saying these msgs are coming from TextMate. I'm working with those folks to try and resolve them. Nonetheless, we do need to have our TextMate grammar updated as it's really out of date. And that's what I'm trying to do. |
I don't see a problem here. I think this is fine to merge. The hint about Joni was meant as a hint, so if you say "Yeah, evaluated, good idea, but don't feel safe with bumping it", I'm fine with that. |
BradWalker
force-pushed
the
markdown_tooling
branch
3 times, most recently
from
67806fb to
934dfc4
Compare
desc: The TextMark JSON description is very much out of date (i.e. years). This change brings in the latest version of the JSON description. In addition, update the TextMark plugin to 0.14.1 version. testing: built with no issues. Loaded a README.md file into the IDE and it previewed correctly.
BradWalker
force-pushed
the
markdown_tooling
branch
from
934dfc4 to
e4c1fc9
Compare
mbien
left a comment
mbien
left a comment
There was a problem hiding this comment.
quickly checked on a readme and compared it to NB 26 and it worked
|
I see some more warnings from tm4e, but at this point in time I think we need to live with them. So from my POV this is still good to go. |
That is correct.. There is a new TextMark/Markdown plugin in beta right now. Figured when it is finally released, maybe do another update then as it should reduce the number of messages. |
4 participants
update: update TextMark/Markdown tooling
desc: The TextMark JSON description is very much out of date (i.e. years). This change brings in the latest version of the JSON description.
In addition, update the TextMark plugin to 0.14.1 version.
testing: built with no issues. Loaded a README.md file into the IDE and it previewed correctly.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)