Skip to content

Remove sun.awt.shell add-opens flag #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbien merged 1 commit into from
Jun 8, 2025
Merged

Remove sun.awt.shell add-opens flag #8563

mbien merged 1 commit into from
Jun 8, 2025

Conversation

@mbien
Copy link
Member

@mbien mbien commented Jun 6, 2025 •
edited
Loading

hopefully not needed anymore since 12d71f4 / #8110 / NB 25

$ ag "sun.awt.shell"

nbbuild/jms-config/desktop.flags
11:--add-opens=java.desktop/sun.awt.shell=ALL-UNNAMED

platform/openide.filesystems/src/org/openide/filesystems/FileUtil.java
135:            assert path.getClass().getName().startsWith("sun.awt.shell") ||
1847:        if (file.getClass().getName().startsWith("sun.awt.shell")) { // NOI18N

https://github.com/search?q=repo%3Aapache%2Fnetbeans%20sun.awt.shell&type=code

tested file chooser UI on windows and linux without the flag in the config file.

@mbien
Remove sun.awt.shell add-opens flag
9977511 
not needed anymore since 12d71f4 / NB 25
@mbien mbien added Code cleanup Label for cleanup done on the Netbeans IDE Platform [ci] enable platform tests (platform/*) UI User Interface ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jun 6, 2025
matthiasblaesing
matthiasblaesing approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local grep agrees with your analysis. An I agree with your conclusion.

@mbien mbien added this to the NB27 milestone Jun 6, 2025
@mbien mbien merged commit 7202a46 into apache:master Jun 8, 2025
32 checks passed
@yashuatla yashuatla mentioned this pull request Jun 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees

No one assigned

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Code cleanup Label for cleanup done on the Netbeans IDE Platform [ci] enable platform tests (platform/*) UI User Interface

Projects

None yet

Milestone

NB27

Development

Successfully merging this pull request may close these issues.

2 participants

@mbien @matthiasblaesing