src: set a default thread name for workers #4664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Jan 6, 2025
santigimeno
reviewed
Jan 6, 2025
Member
santigimeno
left a comment
santigimeno
left a comment
There was a problem hiding this comment.
This looks good to me with Saúl suggestion and tests and documentation added
RafaelGSS
force-pushed
the
set-libuv-default-thread-names
branch
from
40806db to
6670a2c
Compare
RafaelGSS
commented
Jan 6, 2025
saghul
approved these changes
Jan 6, 2025
Contributor
Author
|
I'm currently working on tests to make it more reliable than it is nowadays (there's a chance of a thread not being called executed from the thread pool). |
RafaelGSS
force-pushed
the
set-libuv-default-thread-names
branch
from
82e78cc to
2d16a9d
Compare
1 task
RafaelGSS
force-pushed
the
set-libuv-default-thread-names
branch
from
6e10efe to
e0d951a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm opening this to discuss if that's feasible from libuv point of view. I'm working on nodejs/node#56416 and hardcoding libuv thread names seems something reasonable (I have also talked with @santigimeno previously).
So, I'm opening it here and if I get a green light I can work on tests