Skip to content

events: add EventEmitterAsyncResource to core #41246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 23, 2021
Merged

events: add EventEmitterAsyncResource to core #41246

nodejs-github-bot merged 1 commit into from
Dec 23, 2021

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Dec 19, 2021

Useful as an ecosystem module, also useful as a built in.

Merges @addaleax's implementation EventEmitterAsyncResource into core.

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels Dec 19, 2021
aduh95
aduh95 reviewed Dec 19, 2021
View reviewed changes
@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 19, 2021
aduh95
aduh95 reviewed Dec 19, 2021
View reviewed changes
Flarna
Flarna approved these changes Dec 20, 2021
View reviewed changes
@jasnell jasnell force-pushed the eventemitterasyncresource branch 2 times, most recently from 1693747 to 54275fd Compare December 21, 2021 19:07
Flarna
Flarna reviewed Dec 21, 2021
View reviewed changes
@jasnell jasnell force-pushed the eventemitterasyncresource branch from 2fa4e14 to 79612c5 Compare December 21, 2021 21:34
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 21, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/41589/

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 22, 2021
Open
21 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/41610/ 💚

@github-actions github-actions bot mentioned this pull request Dec 23, 2021
Open
19 tasks
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot merged commit 895c3d9 into nodejs:master Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 23, 2021

Landed in 895c3d9

@jasnell jasnell mentioned this pull request Dec 23, 2021
Closed
This was referenced Dec 24, 2021
Open
Open
Open
Open
Open
This was referenced Dec 29, 2021
Open
Open
Open
@targos targos mentioned this pull request Jan 16, 2022
Merged
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
@Flarna Flarna mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flarna Flarna Flarna approved these changes

@addaleax addaleax addaleax approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell @nodejs-github-bot @addaleax @aduh95 @Flarna