-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
lib: make ALS default to AsyncContextFrame #55552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Qard:default-to-async-context-frame
Nov 2, 2024
Merged
lib: make ALS default to AsyncContextFrame #55552
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Qard:default-to-async-context-frame
Nov 2, 2024
+20
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7bd97e to
15fd51a
Compare
Collaborator
mcollina
approved these changes
Oct 26, 2024
Member
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
anonrig
approved these changes
Oct 26, 2024
avivkeller
reviewed
Oct 26, 2024
15fd51a to
a61b8d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55552 +/- ##
==========================================
- Coverage 88.43% 88.40% -0.03%
==========================================
Files 654 654
Lines 187662 187662
Branches 36117 36101 -16
==========================================
- Hits 165962 165910 -52
- Misses 14938 14989 +51
- Partials 6762 6763 +1
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
|
Landed in 51ae576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_local_storage
AsyncLocalStorage
c++
Issues and PRs that require attention from people who are familiar with C++.
doc
Issues and PRs related to the documentations.
needs-ci
PRs that need a full CI run.
semver-major
PRs that contain breaking changes and should be released in the next major version.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've marked AsyncContextFrame as stable and made it the default. With this we should see the substantial performance improvements to AsyncLocalStorage as the default case for users on future versions of Node.js. Getting more users on this will also help to identify if there are any perf outliers to tweak further.
I hope to land this in v24. I assume we would generally consider this change as major, but I'm happy to downgrade it to minor if we think it's safe to do so.
(Pushing from the train somewhere between Valencia and Barcelona! 🚅💨)
cc @nodejs/diagnostics APMs have had some time to try this out and there have been no further issues after the initial iteration. I'm taking this to mean it seems to be stable. If you disagree, please speak up.
cc @nodejs/electron-installer Note that this makes use of the ContinuationPreservedEmbedderData API which Chromium also makes use of. This likely means Electron will need to change to default to disabled due to this conflict. I believe it's possible for Electron to do some work on their end to enable layering embedder data providers. If anyone is interested in picking this up to support both please reach out, I'm happy to help however I can! 🙂