test_peg_generator C tests fail on Windows ARM

[zooba]

BPO	41172
Nosy	@pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs	bpo-41172: Fix check for compiler in test suite #21400 [3.9] bpo-41172: Fix check for compiler in test suite (GH-21400) #21419

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-07-09.17:55:24.023>
created_at = <Date 2020-06-30.15:57:23.583>
labels = ['3.10', 'tests', '3.9', 'OS-windows']
title = 'test_peg_generator C tests fail on Windows ARM'
updated_at = <Date 2020-07-09.18:12:14.644>
user = 'https://github.com/zooba'

bugs.python.org fields:

activity = <Date 2020-07-09.18:12:14.644>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-09.17:55:24.023>
closer = 'steve.dower'
components = ['Tests', 'Windows']
creation = <Date 2020-06-30.15:57:23.583>
creator = 'steve.dower'
dependencies = []
files = []
hgrepos = []
issue_num = 41172
keywords = ['patch']
message_count = 3.0
messages = ['372699', '373411', '373415']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['21400', '21419']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41172'
versions = ['Python 3.9', 'Python 3.10']

[zooba]

These tests rely on MSVC to do some building, but Windows ARM devices do not currently have a compiler toolset (you need to cross-compile).

We should skip these tests.

Sample build: https://buildbot.python.org/all/#/builders/182/builds/773

Sample traceback:
======================================================================
ERROR: test_error_in_rules (test.test_peg_generator.test_c_parser.TestCParser)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "C:\python\lib\test\test_peg_generator\test_c_parser.py", line 404, in test_error_in_rules
    self.run_test(grammar_source, test_source)
  File "C:\python\lib\test\test_peg_generator\test_c_parser.py", line 83, in run_test
    self.build_extension(grammar_source)
  File "C:\python\lib\test\test_peg_generator\test_c_parser.py", line 80, in build_extension
    generate_parser_c_extension(grammar, Path(self.tmp_path))
  File "C:\python\Tools\peg_generator\pegen\testutil.py", line 104, in generate_parser_c_extension
    compile_c_extension(str(source), build_dir=str(path))
  File "C:\python\Tools\peg_generator\pegen\build.py", line 90, in compile_c_extension
    cmd.run()
  File "C:\python\lib\distutils\command\build_ext.py", line 340, in run
    self.build_extensions()
  File "C:\python\lib\distutils\command\build_ext.py", line 449, in build_extensions
    self._build_extensions_serial()
  File "C:\python\lib\distutils\command\build_ext.py", line 474, in _build_extensions_serial
    self.build_extension(ext)
  File "C:\python\lib\distutils\command\build_ext.py", line 529, in build_extension
    objects = self.compiler.compile(sources,
  File "C:\python\lib\distutils\_msvccompiler.py", line 323, in compile
    self.initialize()
  File "C:\python\lib\distutils\_msvccompiler.py", line 220, in initialize
    vc_env = _get_vc_env(plat_spec)
  File "C:\python\lib\distutils\_msvccompiler.py", line 122, in _get_vc_env
    raise DistutilsPlatformError("Unable to find vcvarsall.bat")
distutils.errors.DistutilsPlatformError: Unable to find vcvarsall.bat

[zooba]

New changeset af56c4f by Steve Dower in branch 'master':
bpo-41172: Fix check for compiler in test suite (GH-21400)
af56c4f

[miss-islington]

New changeset c65ee55 by Miss Islington (bot) in branch '3.9':
bpo-41172: Fix check for compiler in test suite (GH-21400)
c65ee55