Skip to content

use new term in description of --target #150319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 24, 2025
Merged

use new term in description of --target #150319

bors merged 1 commit into from
Dec 24, 2025

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Dec 23, 2025 •
edited
Loading

this changes triple to tuple in --target description

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kivooeo
Copy link
Member

Kivooeo commented Dec 23, 2025

I think I'm in favor of this change. Some of them have four parts, such as «x86_64-unknown-linux-gnu» if I understand correctly

On the other hand, «target triple» is an established term

@tshepang
Copy link
Member Author

tshepang commented Dec 23, 2025

this is like a continuation of a26450c

@Kivooeo
Copy link
Member

Kivooeo commented Dec 23, 2025

this is like a continuation of a26450c

Thanks for the context, yes, then it makes sense

r? me

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 23, 2025

📌 Commit e796582 has been approved by Kivooeo

It is now in the queue for this repository.

@rustbot rustbot assigned Kivooeo and unassigned jieyouxu Dec 23, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 23, 2025
Merged
bors added a commit that referenced this pull request Dec 24, 2025
@bors
Auto merge of #150324 - matthiaskrgr:rollup-cl7wrqn, r=matthiaskrgr
5a7ad8e 
Rollup of 6 pull requests

Successful merges:

 - #149800 (Fix ICE in normalization during closure capture analysis (#149746))
 - #150182 (Don't export upstream monomorphizations from compiler-builtins)
 - #150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - #150308 (Update bors configuration)
 - #150314 (rustc-dev-guide subtree update)
 - #150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2237db5 into rust-lang:main Dec 24, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 24, 2025
@rust-timer
Unrolled build for #150319
a9398e8 
Rollup merge of #150319 - tshepang:triple-is-tuple, r=Kivooeo

use new term in description of --target

this changes _triple_ to _tuple_ in `--target` description
@rustbot rustbot added this to the 1.94.0 milestone Dec 24, 2025
@tshepang tshepang deleted the triple-is-tuple branch December 24, 2025 07:43
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 27, 2025
@bors
Auto merge of #150324 - matthiaskrgr:rollup-cl7wrqn, r=matthiaskrgr
dd018ca 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#149800 (Fix ICE in normalization during closure capture analysis (rust-lang/rust#149746))
 - rust-lang/rust#150182 (Don't export upstream monomorphizations from compiler-builtins)
 - rust-lang/rust#150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - rust-lang/rust#150308 (Update bors configuration)
 - rust-lang/rust#150314 (rustc-dev-guide subtree update)
 - rust-lang/rust#150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Dec 29, 2025
@bors
Auto merge of #150324 - matthiaskrgr:rollup-cl7wrqn, r=matthiaskrgr
e449a2f 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#149800 (Fix ICE in normalization during closure capture analysis (rust-lang/rust#149746))
 - rust-lang/rust#150182 (Don't export upstream monomorphizations from compiler-builtins)
 - rust-lang/rust#150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - rust-lang/rust#150308 (Update bors configuration)
 - rust-lang/rust#150314 (rustc-dev-guide subtree update)
 - rust-lang/rust#150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #150324 - matthiaskrgr:rollup-cl7wrqn, r=matthiaskrgr
59d1dac 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#149800 (Fix ICE in normalization during closure capture analysis (rust-lang/rust#149746))
 - rust-lang/rust#150182 (Don't export upstream monomorphizations from compiler-builtins)
 - rust-lang/rust#150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - rust-lang/rust#150308 (Update bors configuration)
 - rust-lang/rust#150314 (rustc-dev-guide subtree update)
 - rust-lang/rust#150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tshepang @rustbot @Kivooeo @bors @jieyouxu