GH-3253: Apply ServicesResourceTransformer to parquet-jackson

[pan3793]

Rationale for this change

Fix #3253

What changes are included in this PR?

As the title.

Are these changes tested?

Before

After

Are there any user-facing changes?

No.

Closes #3253

[pan3793]

cc @LDVSOFT who reports this issue

[pan3793]

cc @wgtmac

[wgtmac]

I'm not familiar with this. Could you help review this? @gszadovszky

[gszadovszky]

@pan3793, could you elaborate a bit more on what is happening here? The jackson based services are not available currently because of the shading, right? Which means, that parquet-java does not use them. We do not want to make them available. We are shading jackson, so systems depending on parquet-java would not use it directly.

[pan3793]

parquet-java does not use them

@gszadovszky Probably right, because I haven't seen user reports issues related to that. But this can not be proven by UT, because currently, Maven UT always runs against vanilla Jackson libs, class relocation only happens on packaging.

Anyway, we should either correctly transform those service files or purge them.

Generally, applying ServicesResourceTransformer is preferred to keep the functionality completeness of the shaded libs, for example, we generally keep all classes of the shaded lib instead of keeping only the used classes.

[gszadovszky]

@pan3793, can the shaded services interfere with a potential official Jackson library on the classpath? If not, I'm good with this. If yes, we should rather purge the services that we are not using.

[pan3793]

can the shaded services interfere with a potential official Jackson library on the classpath?

No, as long as ServicesResourceTransformer is applied, it relocates both the service interface and implementation class name.

[gszadovszky]

Thank you, @pan3793 for the clarification. I'm OK getting this in.