unix: support SO_REUSEPORT with load balancing for UDP #4419

panjf2000 · 2024-05-23T10:53:39Z

UDP version of #4407

panjf2000 · 2024-05-23T10:53:55Z

/cc @saghul @santigimeno

panjf2000 · 2024-05-23T11:32:08Z

This CI failure should have been fixed by #4417

panjf2000 · 2024-05-27T08:26:03Z

Kindly ping @saghul @santigimeno

saghul · 2024-05-30T07:54:09Z

Merged the test update, can you pl rebase?

panjf2000 · 2024-05-30T08:10:41Z

Merged the test update, can you pl rebase?

Done!

panjf2000 · 2024-05-30T08:30:27Z

A test failure arose:

not ok 51 - fs_event_error_reporting
# exit code 6
# Output from process `fs_event_error_reporting`:
# Assertion failed in /Users/runner/work/libuv/libuv/test/test-fs-event.c on line 1115: `uv_loop_init(loop) == 0` (-24 == 0)

, with which this PR should have nothing to do (hopefully (⊙ˍ⊙))

santigimeno

LGTM. Left a couple of comments.

test/test-udp-reuseport.c

panjf2000 · 2024-05-30T12:06:34Z

Some comments on this? @saghul

docs/src/udp.rst

include/uv.h

src/unix/core.c

src/unix/udp.c

saghul

👏

panjf2000 · 2024-06-03T10:52:46Z

It seems like an irrelevant CI failure:

not ok 321 - tcp_oob
# timeout
# Output from process `tcp_oob`: (no output)

Could you rerun the failed runner manually? @saghul

saghul · 2024-06-03T10:54:30Z

It seems like an irrelevant CI failure:
not ok 321 - tcp_oob
# timeout
# Output from process `tcp_oob`: (no output)
Could you rerun the failed runner manually? @saghul

Done.

panjf2000 · 2024-06-03T11:16:57Z

Great! All checks have passed!
Can we get this PR merged now? @saghul

saghul · 2024-06-03T12:16:17Z

Can we get this PR merged now?

We need some more eyes.

--------- Signed-off-by: Andy Pan <i@andypan.me>

panjf2000 · 2024-06-03T12:28:17Z

Maybe @santigimeno wants to take another look at this?

panjf2000 · 2024-06-11T16:50:08Z

Ping @libuv/collaborators

panjf2000 · 2024-06-19T03:33:03Z

@santigimeno Could you take a quick look at the latest code changes? Thanks!

santigimeno

LGTM with a couple of non-mandatory nits. Sorry it took this long getting to review this: was very busy. Thanks

test/test-udp-reuseport.c

src/unix/core.c

--------- Signed-off-by: Andy Pan <i@andypan.me>

PR-URL: #55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

panjf2000 force-pushed the udp-reuseport branch 2 times, most recently from 5bec9bc to 6ddb837 Compare May 23, 2024 11:19

panjf2000 force-pushed the udp-reuseport branch from cec1055 to 7f49de5 Compare May 30, 2024 08:09

santigimeno approved these changes May 30, 2024

View reviewed changes

test/test-udp-reuseport.c Outdated Show resolved Hide resolved

test/test-udp-reuseport.c Show resolved Hide resolved

test/test-udp-reuseport.c Outdated Show resolved Hide resolved

panjf2000 force-pushed the udp-reuseport branch from 0aa5a36 to 839d420 Compare May 30, 2024 09:40

panjf2000 requested a review from santigimeno May 30, 2024 09:42

panjf2000 mentioned this pull request Jun 3, 2024

tcpkeepalive: distinguish OS versions and use proper time units #4428

Merged

saghul reviewed Jun 3, 2024

View reviewed changes

docs/src/udp.rst Show resolved Hide resolved

include/uv.h Show resolved Hide resolved

src/unix/core.c Show resolved Hide resolved

src/unix/udp.c Show resolved Hide resolved

panjf2000 force-pushed the udp-reuseport branch 2 times, most recently from 4220ed3 to e680b8a Compare June 3, 2024 10:34

saghul approved these changes Jun 3, 2024

View reviewed changes

unix: support SO_REUSEPORT with load balancing for UDP

7e48975

--------- Signed-off-by: Andy Pan <i@andypan.me>

panjf2000 force-pushed the udp-reuseport branch from a89f3e9 to 7e48975 Compare June 3, 2024 12:27

santigimeno approved these changes Jun 20, 2024

View reviewed changes

test/test-udp-reuseport.c Outdated Show resolved Hide resolved

src/unix/core.c Outdated Show resolved Hide resolved

panjf2000 force-pushed the udp-reuseport branch from f219c30 to 964558b Compare June 20, 2024 11:03

Resolve some code review comments

3eed01c

--------- Signed-off-by: Andy Pan <i@andypan.me>

panjf2000 force-pushed the udp-reuseport branch from 964558b to 3eed01c Compare June 20, 2024 11:04

panjf2000 added 2 commits June 20, 2024 11:12

Undo a few formats

25a2546

--------- Signed-off-by: Andy Pan <i@andypan.me>

Update tcp-reuseport

65c9fe4

--------- Signed-off-by: Andy Pan <i@andypan.me>

panjf2000 requested a review from santigimeno June 20, 2024 11:45

santigimeno approved these changes Jun 20, 2024

View reviewed changes

santigimeno merged commit ba24986 into libuv:v1.x Jun 20, 2024

panjf2000 deleted the udp-reuseport branch June 20, 2024 22:17

theanarkh mentioned this pull request Oct 16, 2024

dgram: add UV_UDP_REUSEPORT for udp nodejs/node#55403

Merged

4 tasks

nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Oct 21, 2024

lib: add UV_UDP_REUSEPORT for udp

6a02c27

PR-URL: #55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

aduh95 pushed a commit to nodejs/node that referenced this pull request Oct 23, 2024

lib: add UV_UDP_REUSEPORT for udp

dcbc5fb

PR-URL: #55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024

lib: add UV_UDP_REUSEPORT for udp

878bd56

PR-URL: nodejs#55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024

lib: add UV_UDP_REUSEPORT for udp

f6474a5

PR-URL: nodejs#55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

ruyadorno pushed a commit to nodejs/node that referenced this pull request Nov 27, 2024

lib: add UV_UDP_REUSEPORT for udp

337f61f

PR-URL: #55403 Refs: libuv/libuv#4419 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

unix: support SO_REUSEPORT with load balancing for UDP #4419

unix: support SO_REUSEPORT with load balancing for UDP #4419

Uh oh!

Conversation

panjf2000 commented May 23, 2024

Uh oh!

panjf2000 commented May 23, 2024

Uh oh!

panjf2000 commented May 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

panjf2000 commented May 27, 2024

Uh oh!

saghul commented May 30, 2024

Uh oh!

panjf2000 commented May 30, 2024

Uh oh!

panjf2000 commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

santigimeno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

panjf2000 commented May 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saghul left a comment

Choose a reason for hiding this comment

Uh oh!

panjf2000 commented Jun 3, 2024

Uh oh!

saghul commented Jun 3, 2024

Uh oh!

panjf2000 commented Jun 3, 2024

Uh oh!

saghul commented Jun 3, 2024

Uh oh!

panjf2000 commented Jun 3, 2024

Uh oh!

panjf2000 commented Jun 11, 2024

Uh oh!

panjf2000 commented Jun 19, 2024

Uh oh!

santigimeno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

panjf2000 commented May 23, 2024 •

edited

Loading

panjf2000 commented May 30, 2024 •

edited

Loading