inspector: add protocol methods retrieving sent/received data #58645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lib / src
Add protocol method `Network.dataSent` to buffer request data. And expose protocol methods `Network.getRequestPostData` and `Network.getResponseBody` allowing devtool to retrieve buffered data.
legendecas
force-pushed
the
inspector/data-sent-api
branch
from
0d15711 to
5b2f8a5
Compare
legendecas
added
the
inspector
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58645 +/- ##
========================================
Coverage 90.15% 90.15%
========================================
Files 636 637 +1
Lines 187891 188001 +110
Branches 36879 36899 +20
========================================
+ Hits 169386 169493 +107
+ Misses 11272 11245 -27
- Partials 7233 7263 +30
🚀 New features to boost your workflow:
|
Collaborator
Member
Author
|
@nodejs/inspector would you mind taking a look? Thank you! |
islandryu
approved these changes
Jun 19, 2025
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5a14ea6 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
Add protocol method `Network.dataSent` to buffer request data. And expose protocol methods `Network.getRequestPostData` and `Network.getResponseBody` allowing devtool to retrieve buffered data. PR-URL: #58645 Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
Add protocol method `Network.dataSent` to buffer request data. And expose protocol methods `Network.getRequestPostData` and `Network.getResponseBody` allowing devtool to retrieve buffered data. PR-URL: #58645 Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
Add protocol method `Network.dataSent` to buffer request data. And expose protocol methods `Network.getRequestPostData` and `Network.getResponseBody` allowing devtool to retrieve buffered data. PR-URL: #58645 Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
|
@legendecas sorry for tagging, but I have a question, from my usage looks like this implementation covers From my understanding we could hook into auto decompress option in http client and then use that depending on conent-encoding in getResponseBody. Just trying to figure out if this is intended or missed? |
Member
Author
|
@capJavert yes, there is a PR #61226 for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protocol method
Network.dataSentto buffer request data. Andexpose protocol methods
Network.getRequestPostDataandNetwork.getResponseBodyallowing devtool to retrieve buffered data.