tools: improve log output of create-release-proposal
#61028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
targos
approved these changes
Dec 12, 2025
aduh95
added
the
author ready
richardlau
approved these changes
Dec 12, 2025
aduh95
added
the
commit-queue
cjihrig
approved these changes
Dec 12, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6322071 |
aduh95
added a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #61028 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 12, 2026
PR-URL: #61028 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #61028 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 19, 2026
PR-URL: #61028 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#61028 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was bothering me that we were logging out the
BOT_TOKEN, the solution was simply to moveset -exafter the preliminary checks. We were also not checking for the presence ofgit-nodein the dependency checks, and not explicitly listing the missing deps.