feat: allow creating strongly typed slices and maps from PHP values with type utilities #1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
changed the title
alexandre-daubois
approved these changes
Oct 20, 2025
Member
alexandre-daubois
left a comment
alexandre-daubois
left a comment
There was a problem hiding this comment.
Happy to see better error handling on this part and the use of generics. I'm always 👍 on better typing.
Looks good to me if CI agrees!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved type conversion API for extensions, to allow converting PHP arrays to strongly typed Go maps and slices such as
map[int]stringor[]string.Also, this patches improves error handling.
(Extracted from #1927)