-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Support "bpo-" in Misc/NEWS #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doc/tools/extensions/pyspecific.py
Outdated
| node = nodes.strong(text, text) | ||
| return [node] | ||
| content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | ||
| content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\b ? I think you overwrote the \1 :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right. Now fixed.
Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.
Doc/tools/extensions/pyspecific.py
Outdated
|
|
||
| ISSUE_URI = 'https://bugs.python.org/issue%s' | ||
| SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s' | ||
| SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be master rather than 3.6 on this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My patch for another issue will address this, I think 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and updated here since I'm already changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
Doc/tools/extensions/pyspecific.py
Outdated
| node = nodes.strong(text, text) | ||
| return [node] | ||
| content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | ||
| content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
(cherry picked from commit 79ab8be)
Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py
Change the url to 2.7 (cherry picked from commit 79ab8be)
* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma
* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma
Update email.message.rst
…new__ override, rely on __add__ only. Clarify with reviewer note. (python#1 branch)
Co-authored-by: Bénédikt Tran <[email protected]>
No description provided.