gh-103553: Improve test_inspect: add more assertions, remove unused
#103554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jacobtylerwalls
approved these changes
Apr 15, 2023
Ismaelkadir
approved these changes
Apr 15, 2023
|
Merge |
Member
Author
|
@Ismaelkadir Hi! :) I see that you've just joined GitHub and you take interest in CPython's development. There you can see how we do code reviews and how, who, and when merge PRs. Please, feel free to ask any question you have about the process. |
hauntsaninja
approved these changes
Apr 15, 2023
Contributor
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, this looks great!
hauntsaninja
added
needs backport to 3.11
Contributor
|
Thanks @sobolevn for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-103568 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup is quite straight-forward :)
test_inspect#103553