Skip to content

Conversation

@uriyyo
Copy link
Member

@uriyyo uriyyo commented Nov 25, 2020

Remove loop parameter from asyncio.open_connection and asyncio.start_server functions.

This PR is a part of the loop parameter removal that should be done in the scope of python 3.10.

https://bugs.python.org/issue42392

@uriyyo
Copy link
Member Author

uriyyo commented Nov 25, 2020

@1st1 @asvetlov

I have a question regarding classes defined in asyncio.streams.
Those classes accept loop parameters, maybe it makes sense to rewrite them to use the new _LoopBoundMixin class?

@asvetlov
Copy link
Contributor

Sure yes. Good idea.

@uriyyo uriyyo requested a review from tiran as a code owner November 25, 2020 21:10
@asvetlov
Copy link
Contributor

Thanks!

@uriyyo
Copy link
Member Author

uriyyo commented Nov 26, 2020

@asvetlov I ended up with not using _LoopBoundMixin for classes defined in asyncio.streams because there was no deprecation warning regarding loop parameter removal so I think it can lead to some unpredictable bugs in user code.

@asvetlov
Copy link
Contributor

Both fine with me. These constructors are private, people should not use them directly. But some code can violate this principle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants