Skip to content

fix(compass): remove type whitelist #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StewartJingga merged 1 commit into from
Jun 7, 2022
Merged

fix(compass): remove type whitelist #147

StewartJingga merged 1 commit into from
Jun 7, 2022

Conversation

@mabdh
Copy link
Member

@mabdh mabdh commented Jun 7, 2022

No description provided.

@mabdh mabdh requested a review from StewartJingga June 7, 2022 08:56
@coveralls
Copy link

coveralls commented Jun 7, 2022

Pull Request Test Coverage Report for Build 2453344100

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 81.171%
Totals Coverage Status
Change from base Build 2446835671: -0.03%
Covered Lines: 4492
Relevant Lines: 5534
💛 - Coveralls

@mabdh mabdh linked an issue Jun 7, 2022 that may be closed by this pull request
search filter[type] does not work #148
Closed
@mabdh mabdh marked this pull request as ready for review June 7, 2022 09:11
StewartJingga
StewartJingga approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StewartJingga StewartJingga merged commit 609ce4d into main Jun 7, 2022
@StewartJingga StewartJingga deleted the fix-search-filter branch June 7, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

search filter[type] does not work

4 participants

@mabdh @coveralls @StewartJingga