Skip to content

chore: add tests to improve coverage #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StewartJingga merged 14 commits into from
Aug 4, 2022
Merged

chore: add tests to improve coverage #156

StewartJingga merged 14 commits into from
Aug 4, 2022

Conversation

@GrayFlash
Copy link
Member

@GrayFlash GrayFlash commented Jun 30, 2022

closes #143

@GrayFlash GrayFlash self-assigned this Jun 30, 2022
@coveralls
Copy link

coveralls commented Jun 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2791707960

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+6.07%) to 85.74%
Files with Coverage Reduction New Missed Lines %
core/asset/patch.go 12 77.27%
Totals Coverage Status
Change from base Build 2654050687: 6.07%
Covered Lines: 4726
Relevant Lines: 5512
💛 - Coveralls

@GrayFlash GrayFlash marked this pull request as ready for review July 4, 2022 09:03
@GrayFlash GrayFlash requested a review from StewartJingga July 4, 2022 12:07
StewartJingga
StewartJingga reviewed Jul 5, 2022
View reviewed changes
@GrayFlash GrayFlash requested a review from StewartJingga July 7, 2022 14:34
StewartJingga
StewartJingga approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StewartJingga StewartJingga merged commit b5a3ea5 into main Aug 4, 2022
@StewartJingga StewartJingga deleted the improve-coverage branch August 4, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

@GrayFlash GrayFlash

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase coverage to 87%

4 participants

@GrayFlash @coveralls @StewartJingga