feat: manage assets with URN for GET/DELETE #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravisuhag
changed the title
sudo-suhas
force-pushed
the
manage-assets-with-urn
branch
from
a72004d to
6d361f4
Compare
- On the service layer, for get and delete, check if the given ID is a UUID and call corresponding method on repository (ex: GetByID or GetByURN). This introduces a limitation into the system where if an asset's URN is a UUID, the get and delete calls will fail. This limitation is considered acceptable in the short term and in the long term, the plan is to drop support for get or delete by ID. ID will be internal to Compass. - On the repository layer for PG and ES, add get and delete by URN variants. - Drop the Find method on asset repository and replace usages with GetWithURN. BREAKING CHANGE: The interface for asset Repository and DiscoveryRepository have been changed - methods have been renamed and new methods have been added.
sudo-suhas
force-pushed
the
manage-assets-with-urn
branch
from
6d361f4 to
d80fbbf
Compare
Pull Request Test Coverage Report for Build 2867002035
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUID and call corresponding method on repository (ex: GetByID or
GetByURN). This introduces a limitation into the system where if an
asset's URN is a UUID, the get and delete calls will fail. This
limitation is considered acceptable in the short term and in the long
term, the plan is to drop support for get or delete by ID. ID will be
internal to Compass.
variants.
GetWithURN.
BREAKING CHANGE: The interface for asset Repository and
DiscoveryRepository have been changed - methods have been renamed and
new methods have been added.
Closes #162