Skip to content

feat: new UpsertAsset api with replace strategy instead of patch/merge #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ravisuhag merged 7 commits into from
Sep 26, 2022
Merged

feat: new UpsertAsset api with replace strategy instead of patch/merge #171

ravisuhag merged 7 commits into from
Sep 26, 2022

Conversation

@StewartJingga
Copy link
Contributor

@StewartJingga StewartJingga commented Sep 12, 2022

Close #160

@StewartJingga StewartJingga added the enhancement New feature or request label Sep 12, 2022
@StewartJingga StewartJingga self-assigned this Sep 12, 2022
@coveralls
Copy link

coveralls commented Sep 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3102594224

  • 83 of 92 (90.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 86.146%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/server/v1beta1/asset.go 82 91 90.11%
Totals Coverage Status
Change from base Build 2916461289: 0.3%
Covered Lines: 4788
Relevant Lines: 5558
💛 - Coveralls

sudo-suhas
sudo-suhas reviewed Sep 13, 2022
View reviewed changes
sudo-suhas
sudo-suhas reviewed Sep 20, 2022
View reviewed changes
sudo-suhas
sudo-suhas reviewed Sep 20, 2022
View reviewed changes
sudo-suhas
sudo-suhas reviewed Sep 22, 2022
View reviewed changes
@sudo-suhas
Copy link
Contributor

sudo-suhas commented Sep 26, 2022

@StewartJingga shall we merge in these changes?

@ravisuhag ravisuhag merged commit a9ec40b into main Sep 26, 2022
@ravisuhag ravisuhag deleted the new-upsert-api branch September 26, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudo-suhas sudo-suhas sudo-suhas approved these changes

@bsushmith bsushmith Awaiting requested review from bsushmith

Assignees

@StewartJingga StewartJingga

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ability to overwrite asset instead of merge

5 participants

@StewartJingga @coveralls @sudo-suhas @ravisuhag