Skip to content

Conversation

@StewartJingga
Copy link
Contributor

Closing #170

  1. New CreateAssetProbe api ✅
  2. New asset.Probe model ✅
  3. New asset_probes db table ✅

@StewartJingga StewartJingga self-assigned this Sep 19, 2022
@coveralls
Copy link

coveralls commented Sep 20, 2022

Pull Request Test Coverage Report for Build 3156811300

  • 105 of 121 (86.78%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 86.115%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/asset/errors.go 2 3 66.67%
core/asset/service.go 16 17 94.12%
internal/server/v1beta1/asset.go 41 47 87.23%
internal/store/postgres/asset_repository.go 35 43 81.4%
Files with Coverage Reduction New Missed Lines %
core/asset/errors.go 1 84.62%
core/asset/service.go 1 97.92%
Totals Coverage Status
Change from base Build 3127448020: -0.03%
Covered Lines: 4887
Relevant Lines: 5675

💛 - Coveralls

@ravisuhag ravisuhag linked an issue Sep 26, 2022 that may be closed by this pull request
@sudo-suhas
Copy link
Contributor

@StewartJingga could you rebase and resolve the conflicts?

Copy link
Contributor

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StewartJingga StewartJingga merged commit b96ebcc into main Sep 30, 2022
@StewartJingga StewartJingga deleted the asset-probe branch September 30, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Asset's Status

4 participants