Skip to content

fix: require timestamp for adding asset probe #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sudo-suhas merged 1 commit into from
Oct 28, 2022
Merged

fix: require timestamp for adding asset probe #183

sudo-suhas merged 1 commit into from
Oct 28, 2022

Conversation

@sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Oct 27, 2022

Fixes #182

@sudo-suhas sudo-suhas mentioned this pull request Oct 27, 2022
Merged
@coveralls
Copy link

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3336740978

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.092%
Totals Coverage Status
Change from base Build 3336321828: 0.007%
Covered Lines: 4878
Relevant Lines: 5666
💛 - Coveralls

StewartJingga
StewartJingga approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas sudo-suhas merged commit 34784ad into main Oct 28, 2022
@sudo-suhas sudo-suhas deleted the require-probe-timestamp branch October 28, 2022 06:52
@Ghjkvvgj
Copy link

Ghjkvvgj commented Nov 4, 2022 •
edited
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: probe's timestamp value is set to default time value instead of empty if not defined

5 participants

@sudo-suhas @coveralls @Ghjkvvgj @StewartJingga