Skip to content

feat: serve grpc on different port #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ravisuhag merged 5 commits into from
Dec 6, 2022
Merged

feat: serve grpc on different port #189

ravisuhag merged 5 commits into from
Dec 6, 2022

Conversation

@StewartJingga
Copy link
Contributor

@StewartJingga StewartJingga commented Nov 30, 2022

  • Use odpf/salt/mux package to server grpc on different port
  • Fix backward compatibility issues when updating salt version on salt/term package

Relates to raystack/salt#63

@StewartJingga StewartJingga added the enhancement New feature or request label Nov 30, 2022
@StewartJingga StewartJingga self-assigned this Nov 30, 2022
@coveralls
Copy link

coveralls commented Nov 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3600176552

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.183%
Totals Coverage Status
Change from base Build 3529274793: 0.0%
Covered Lines: 4965
Relevant Lines: 5761
💛 - Coveralls

sudo-suhas
sudo-suhas requested changes Dec 2, 2022
View reviewed changes
sudo-suhas
sudo-suhas approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@sudo-suhas sudo-suhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravisuhag ravisuhag merged commit f01ec6f into main Dec 6, 2022
@ravisuhag ravisuhag deleted the split-grpc-port branch December 6, 2022 18:35
@sudo-suhas sudo-suhas mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudo-suhas sudo-suhas sudo-suhas approved these changes

Assignees

@StewartJingga StewartJingga

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@StewartJingga @coveralls @sudo-suhas @ravisuhag