Skip to content

feat: support fetching specific asset version with URN #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sudo-suhas merged 1 commit into from
Feb 21, 2023
Merged

feat: support fetching specific asset version with URN #207

sudo-suhas merged 1 commit into from
Feb 21, 2023

Conversation

@sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Feb 20, 2023

Closes #190

@sudo-suhas sudo-suhas force-pushed the get-asset-version-urn branch from fee0658 to 0e000aa Compare February 20, 2023 09:44
@coveralls
Copy link

coveralls commented Feb 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4222057431

  • 29 of 39 (74.36%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 86.123%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/asset_repository.go 25 35 71.43%
Files with Coverage Reduction New Missed Lines %
internal/store/postgres/asset_repository.go 1 77.62%
Totals Coverage Status
Change from base Build 3993724900: 0.05%
Covered Lines: 5002
Relevant Lines: 5808
💛 - Coveralls

@sudo-suhas sudo-suhas requested a review from haveiss February 20, 2023 09:46
@sudo-suhas sudo-suhas merged commit c96e577 into main Feb 21, 2023
@sudo-suhas sudo-suhas deleted the get-asset-version-urn branch February 21, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haveiss haveiss haveiss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support fetching an asset with specific version using it's URN

4 participants

@sudo-suhas @coveralls @haveiss