-
Notifications
You must be signed in to change notification settings - Fork 9
fix: store, retrieve asset.url #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sudo-suhas
commented
Feb 21, 2023
- Add column to assets table for URL.
- Store the asset's URL field in DB as part of insert/upsert.
- Retrieve the asset's URL field from DB for fetch APIs.
- Refactor UPDATE statement to use squirrel for easier maintenance.
- Add column to assets table for URL. - Store the asset's URL field in DB as part of insert/upsert. - Retrieve the asset's URL field from DB for fetch APIs. - Refactor UPDATE statement to use squirrel for easier maintenance.
Pull Request Test Coverage Report for Build 4232473912
💛 - Coveralls |
| a.service as service, | ||
| a.description as description, | ||
| a.data as data, | ||
| COALESCE(a.url, '') as url, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how this compared to set url default to '' when altering table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Altering a table with default value used to take a lock for updating all rows (which would block reads and writes). This looks to have been fixed in PG 11 but I wasn't aware of that while making these changes.
Pull Request Test Coverage Report for Build 4232473912Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 4232473912Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |