fix(app): enable auto-accept keybind regardless of permission config#16259
Merged
adamdotdevin merged 3 commits intoanomalyco:devfrom Mar 6, 2026
Merged
fix(app): enable auto-accept keybind regardless of permission config#16259adamdotdevin merged 3 commits intoanomalyco:devfrom
adamdotdevin merged 3 commits intoanomalyco:devfrom
Conversation
The Cmd+Shift+A keybind for toggling auto-accept permissions was permanently disabled when no permission prompt rules were configured. The permissionsEnabled() check prevented the command from entering the keymap, making the keybind dead for most users. Remove the permissionsEnabled() gate from the disabled condition so the keybind works whenever a session is active.
The @opentui/solid package moved its bun plugin export from `scripts/solid-plugin` to `bun-plugin`. Also add a fallback for `parser.worker.js` to check the root node_modules when the package is hoisted in the monorepo.
The Cmd+Shift+A keybind was dead when no session was active or when switching projects. Three changes: 1. Keybind now works on the "New session" screen by toggling auto-accept at the directory level (key: base64(dir)/*). 2. When config has `permission: "allow"`, auto-accept is enabled by default for that directory on first visit. 3. The chevron icon correctly reflects the active state on both "New session" and active session screens. Removes the ephemeral `pendingAutoAccept` local state in favor of the persisted directory-level auto-accept store.
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
qdddddd
pushed a commit
to qdddddd/opencode
that referenced
this pull request
Mar 7, 2026
manno23
pushed a commit
to manno23/opencode
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16258
Type of change
What does this PR do?
The
Cmd+Shift+Aauto-accept keybind was dead in two scenarios:disabled: !params.idprevented the keybind when no session was active.permission: "allow"config:permissionsEnabled()returnedfalsesince there are no non-allow rules, gating the keybind permanently.Changes:
base64(dir)/*) so the toggle works without an active session.permission: "allow", the directory-level auto-accept is enabled by default on first visit. Respects explicit user toggle (if user disables, it stays disabled).»icon now reflects the correct state on both "New session" and active session screens.pendingAutoAcceptlocal state in favor of the persisted directory-level store.@opentui/solidimport path (bun-plugininstead ofscripts/solid-plugin) and added fallback for hoistedparser.worker.js.Related: #7928, #1813
How did you verify your code works?
Screenshots / recordings
Before — chevron
»inactive on New Session,Cmd+Shift+Adoes nothing:After — chevron
»active, toggle works on New Session screen, toasts confirm state:Checklist