Updated Signtool-exe.md to include coming crypto changes to the tool#21048
Merged
tdykstra merged 15 commits intodotnet:masterfrom Nov 2, 2020
Merged
Updated Signtool-exe.md to include coming crypto changes to the tool#21048tdykstra merged 15 commits intodotnet:masterfrom
tdykstra merged 15 commits intodotnet:masterfrom
Conversation
|
|
Youssef1313
reviewed
Oct 13, 2020
Youssef1313
reviewed
Oct 13, 2020
Youssef1313
reviewed
Oct 13, 2020
Youssef1313
reviewed
Oct 13, 2020
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Contributor
Author
|
@Youssef1313 @tdykstra any update on this PR? SignTool changes are live and this doc should reflect those changes. Thanks |
tdykstra
approved these changes
Oct 30, 2020
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
LGTM, left some suggestions for style consistency.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Contributor
Author
Thank you @tdykstra for the suggested changes! I have approved them. |
Contributor
|
Thanks -- I'll merge as soon as the build finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*Announcing the updates coming to SignTool in the 20236 kit builds
*Aligned documentation between win32 and seccrypto SignTool exe docs
*Added examples for SignTool
Fixes #Issue_Number (if available)
I am a MSFT PM on the Windows code signing feature team (we own Signtool.exe)