[easy] undefined name in Lib/test/mock_socket.py #84642

Activity

1. vstinner commented on Apr 30, 2020

   

   vstinner

   on Apr 30, 2020

   MemberAuthor

   More actions

   pyflakes found the following issues in sendall():

   Lib/test/mock_socket.py:95:21 undefined name 'data'
   Lib/test/mock_socket.py:96:28 undefined name 'data'
   Lib/test/mock_socket.py:97:20 undefined name 'data'

   Code:

       def sendall(self, buffer, flags=None):
           self.last = data
           self.output.append(data)
           return len(data)
   
       def send(self, data, flags=None):
           self.last = data
           self.output.append(data)
           return len(data)

   I guess that sendall() buffer parameter should be renamed to data.
2. vstinner

   added

   3.9 (EOL)end of lifeend of life

   testsTests in the Lib/test dirTests in the Lib/test dir

   easy

   on Apr 30, 2020
3. vstinner commented on Apr 30, 2020

   

   vstinner

   on Apr 30, 2020

   MemberAuthor

   More actions

   Another one:

   Lib/test/test_frame.py:53:17 undefined name 'inner'

   I guess that self.inner() should be used instead of inner(). In practice, it's dead code, but fixing it would make pyflakes happier :-)
4. vstinner commented on Apr 30, 2020

   

   vstinner

   on Apr 30, 2020

   MemberAuthor

   More actions

   Another one:

   Lib/test/test_json/test_recursion.py:55:24 undefined name 'pyjson'

   Code:

       def test_defaultrecursion(self):
           class RecursiveJSONEncoder(self.json.JSONEncoder):
               recurse = False
               def default(self, o):
                   if o is JSONTestObject:
                       if self.recurse:
                           return [JSONTestObject]
                       else:
                           return 'JSONTestObject'
                   return pyjson.JSONEncoder.default(o)

   Here I'm not sure. *Maybe* pyjson.JSONEncoder should be replaced with self.json.JSONEncoder?
5. vstinner commented on May 1, 2020

   

   vstinner

   on May 1, 2020

   MemberAuthor

   More actions

   Another one:

   Lib/unittest/test/test_program.py:191:40 undefined name 'hasInstallHandler'

   Code:

       def testBufferCatchFailfast(self):
           program = self.program
           for arg, attr in (('buffer', 'buffer'), ('failfast', 'failfast'),
                         ('catch', 'catchbreak')):
               if attr == 'catch' and not hasInstallHandler:
                   continue
               ...

   attr is never equal to 'catch' and so it's just dead code which can be removed.
6. furkanonder commented on May 1, 2020

   

   furkanondermannequin

   on May 1, 2020

   Mannequin

   More actions

   Hello,
   I sent a PR that corrects variable and function names.
   I'm not sure how to fix it for Lib/test/test_json/test_recursion.py:55:24 so I didn't make any changes.
7. miss-islington commented on May 1, 2020

   

   miss-islington

   on May 1, 2020

   Contributor

   More actions

   New changeset 719e14d by Furkan Önder in branch 'master':
   bpo-40462: fix variable and function names (GH-19832)
   719e14d
8. corona10 commented on May 1, 2020

   

   corona10

   on May 1, 2020

   Member

   More actions

   @vstinner
   IMHO we should create backport patch for 3.8 and 3.7
   3.8 and 3.7 has same codes for this.

   https://github.com/python/cpython/blob/3.8/Lib/test/mock_socket.py#L95
9. vstinner commented on May 5, 2020

   

   vstinner

   on May 5, 2020

   MemberAuthor

   More actions

   IMHO we should create backport patch for 3.8 and 3.7

   It's deadcode, I don't think that it's worth it. But it's up to you. If you consider that it's worth it, go ahead and backport the fix.
10. vstinner commented on May 14, 2020

    

    vstinner

    on May 14, 2020

    MemberAuthor

    More actions

    New changeset 4b972fa by Victor Stinner in branch 'master':
    bpo-40462: Fix typo in test_json (GH-20094)
    4b972fa
11. vstinner commented on May 14, 2020

    

    vstinner

    on May 14, 2020

    MemberAuthor

    More actions

    Thanks for the fix Furkan Önder!
12. vstinner

    closed this as completedon May 14, 2020
13. furkanonder commented on May 14, 2020

    

    furkanondermannequin

    on May 14, 2020

    Mannequin

    More actions

    You are welcome :=)
14. ezio-melotti

    transferred this issue fromon Apr 10, 2022