Merged
Conversation
Merged
felixarntz
reviewed
Dec 14, 2022
Member
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger Almost LGTM, just one tiny thing, and another observation to handle separately.
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger Left some nit-pick feedbacks
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger Left some nit-pick feedback.
- As per the issue acceptance criteria, the folder name is
testsand PR usedtest. which needs to be updated.
Contributor
Author
@mukeshpanchal27 the AC actually uses |
Member
|
Thanks @jjgrainger for clarification. |
mukeshpanchal27
approved these changes
Dec 16, 2022
Member
mukeshpanchal27
left a comment
There was a problem hiding this comment.
LGTM. Great work, @jjgrainger
bordoni
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Add application files check * Add .phar extension and alphabetize the array * add .DS_Store to exclusion list * Updates * Abstract throw_error
bordoni
added a commit
that referenced
this pull request
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initial project files and directories.
SECURITY.md,CODE_OF_CONDUCT.mdandLICENSEwordpress/plugin-checknamespace, instead of10up/plugin-checkknowing this repo will be moved across at a later date.Closes #1