Skip to content

Keep ICC profiles by default #244

Closed
Closed
Keep ICC profiles by default#244
Labels
breaking changeThis will have to be included with a major version as it breaks backwards compatibility.enhancementNew feature or request
Milestone
Eleventy Image v6.0.0

Description

@pcarrier
pcarrier
opened on Sep 10, 2024

sharp exposes keepIccProfile, which is important to retain all the colors of Display-P3 and AdobeRGB images.

For example, check out the intensity of the green on the signage and table @ https://nothing.pcarrier.com/posts/riviere-des-parfums/ compared to the (linked) original images.
If your display supports significantly more than sRGB, the difference should be notable.

Activity

  1. Imagezachleat
    added this to the Eleventy Image v6.0.0 milestone on Dec 20, 2024
  2. Imagezachleat
    added
    duplicateThis issue or pull request already exists
    enhancementNew feature or request
    on Dec 20, 2024

  3. zachleat commented on Dec 20, 2024

    @zachleat
    zachleat
    on Dec 20, 2024
    Member

    Enabled by #52, shipping soon with v6.0.0-beta.1

    If you think we should change the default in Eleventy Image, please let me know!

  4. Imagezachleat
    closed this as completedon Dec 20, 2024

  5. ScreenDream commented on Jan 2, 2025

    @ScreenDream
    ScreenDream
    on Jan 2, 2025

    +1 I would vote to keep ICC profiles as default.

  6. Imagezachleat
    changed the title [-]Control over ICC profiles[/-] [+]Keep ICC profiles by default[/+] on Jan 2, 2025
  7. Imagezachleat
    added a commit that references this issue on Jan 2, 2025

    Breaking: change default to keep icc profiles #244

    263f5fa
  8. Imagezachleat
    added
    breaking changeThis will have to be included with a major version as it breaks backwards compatibility.
    and removed
    duplicateThis issue or pull request already exists
    on Jan 2, 2025

  9. zachleat commented on Jan 2, 2025

    @zachleat
    zachleat
    on Jan 2, 2025
    Member

    .keepIccProfile() will be enabled by default in Eleventy Image v6.0.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking changeThis will have to be included with a major version as it breaks backwards compatibility.enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions