[taiyang-li]

Changelog category (leave one):

• Performance Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Improve prewhere optimization for conditions like func(primary_column) = 'xx' and column in (xxx)

For example:

• When prewhere condition is like lower(country) = 'cn', and country is one of the primary index columns, we should not move the condition to the end of prewhere even if move_primary_key_columns_to_end_of_prewhere is enabled. Because lower(country) = 'cn' can't make use of primary index. We should decide its position in prewhere conditions according to compressed column sizes and estimated rows(if allow_statistics_optimize is enabled).
• When prewhere condition is like value in ('x', 'y', 'z'), its estimated selectivity is always 1.0 because current process about in functions is not right in ConditionSelectivityEstimator::extractAtomFromTree. This PR fixed it.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

[clickhouse-gh]

Workflow [PR], commit [96fc362]

Summary: ❌

job_name	test_name	status	info	comment
Stateless tests (amd_tsan, parallel, 2/2)		failure
	03094_grouparraysorted_memory	FAIL
	02406_try_read_datetime64_bug	FAIL
	Exception in test runner	FAIL
	Sanitizer assert (in stderr.log)	FAIL
	Killed by signal (in clickhouse-server.log or clickhouse-server.err.log)	FAIL
Stateless tests (amd_debug, distributed plan, s3 storage, parallel)		failure
	02443_detach_attach_partition	FAIL
Stateless tests (arm_binary, parallel)		failure
	01825_new_type_json_ghdata_insert_select	FAIL
Integration tests (arm_binary, distributed plan, 1/4)		failure
	test_global_overcommit_tracker/test.py::test_global_overcommit	FAIL
Stress test (amd_tsan)		failure
	Server died	FAIL
	Hung check failed, possible deadlock found (see hung_check.log)	FAIL
	Killed by signal (in clickhouse-server.log)	FAIL
	Fatal message in clickhouse-server.log (see fatal_messages.txt)	FAIL
	Killed by signal (output files)	FAIL
	Found signal in gdb.log	FAIL

[taiyang-li]

@alexey-milovidov hope for your reviews, thanks very much!

[hanfei1991]

looks like __set_String_4653864928722945989_14468210011007111410 is not a stable name, that's why test failed, can we replace it with __set_String by sed command in test?

[taiyang-li]

@hanfei1991 thanks for your reviews! Let's wait for next CI.