Traffic Monitor logs not consistent #5373

Activity

1. smalenfant

   added

   bugsomething isn't working as intendedsomething isn't working as intended

   Traffic Monitorrelated to Traffic Monitorrelated to Traffic Monitor

   on Dec 14, 2020
2. tcfdev commented on Dec 14, 2020

   

   tcfdev

   on Dec 14, 2020

   Collaborator

   More actions

   Looks like both logging events are created in CreateStats(...), once in the beginning of the function under addAvailableData(...) and again at the end of the function within addPerSecStats(...) -> addDSPerSecStats(...). They do look awfully similar, but I don’t know if they have different intentions or it’s more by happenstance.
3. tcfdev commented on Jan 20, 2021

   

   tcfdev

   on Jan 20, 2021

   Collaborator

   More actions

   After doing some further research, I've found that the health.Event{} is not quite consistent in the 5 spots it's created. Additionally, there appears to be an assumption that the name/xmlid is the same as the hostname in all declarations. For example, the 2 Delivery Service events are:

   package ds

   stat.go, 116:

   return health.Event{
   	Time:        health.Time(time.Now()),
   	Description: desc,
   	Name:        dsName.String(),
   	Hostname:    dsName.String(),
   	Type:        "Delivery Service",
   	Available:   stat.CommonStats.IsAvailable.Value,
   }

   stat.go, 328:

   return health.Event{
   	Time:        health.Time(time.Now()),
   	Description: desc,
   	Name:        dsName.String(),
   	Hostname:    dsName.String(),
   	Type:        "DELIVERYSERVICE",
   	Available:   stat.CommonStats.IsAvailable.Value,
   }

   It would be worthwhile to further investigate the name/hostname. If the hostname information is indeed part of the ingress, then it should be used appropriately. Also, it is my opinion that the Type field should be a typedef of sorts to ensure consistency. Something like the type definition example found at: https://programming.guide/go/define-enumeration-string.html. Lastly, even if the consistency were applied and the name addressed for the logs, the same log message would appear twice. It is also worth evaluating both Delivery Service events and assuring they are indeed logging separate logic.
4. shamrickus

   closed this as completedin #6292on Oct 22, 2021
5. zrhoffman

   added this to the 6.0.1 milestone on Nov 5, 2021