Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add enableDebug to config - #357

Merged
sadick254 merged 7 commits into
atom:masterfrom
aminya:lazy-debug
Dec 16, 2020
Merged

sadick254 merged 7 commits into
atom:masterfrom
aminya:lazy-debug

Conversation

@aminya

@aminya aminya commented Dec 16, 2020 •

Copy link
Copy Markdown
Contributor

Description of the Change

  • Makes debug loading lazy and hides it behind a setting. This is inline with Atom's snapshot system
  • This adds a config which allows to enable or disable debug

Alternate Designs

Benefits

  • Allows spell-check to be included in the snapshot -> Unblocks Upgrade to electron 9.3.5 atom#21777
  • Adding UI for debugging makes it easier for normal users to enable/disable debugging.
  • No extra overhead because of debug package.
  • Loading time is decreased from 29ms to 15ms

Possible Drawbacks

N/A

Applicable Issues

Fixes #356

@aminya
aminya marked this pull request as ready for review December 16, 2020 04:24
@aminya

aminya commented Dec 16, 2020 •

Copy link
Copy Markdown
Contributor Author

@sadick254 This probably unblocks Electron upgrade

@sadick254 sadick254 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requiring debug breaks Atom's snapshot (blocking Electron upgrade)

2 participants