Skip to content

[24.0 backport] configfile: Initialize nil AuthConfigs - #4450

Merged
thaJeztah merged 1 commit into
docker:24.0from
vvoland:fix-issue-4414-Danial-Gharib-24
Jul 19, 2023
Merged

thaJeztah merged 1 commit into
docker:24.0from
vvoland:fix-issue-4414-Danial-Gharib-24

Conversation

@vvoland

@vvoland vvoland commented Jul 19, 2023

Copy link
Copy Markdown
Collaborator

Initialize AuthConfigs map if it's nil before returning it. This fixes fileStore.Store nil dereference panic when adding a new key to the map.

(cherry picked from commit ad43df5)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Initialize AuthConfigs map if it's nil before returning it.
This fixes fileStore.Store nil dereference panic when adding a new key
to the map.

Signed-off-by: Danial Gharib <danial.mail.gh@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit ad43df5)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 24.0.5 milestone Jul 19, 2023

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit ced0996 into docker:24.0 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants