Repository navigation
test: re-enable Node.js tests that now pass with BoringSSL - #55095
Merged
Merged
Conversation
* test: re-enable Node.js tests that now pass with BoringSSL Most of these were disabled because BoringSSL behaved differently from OpenSSL. Upstream Node.js made the tests BoringSSL-aware in nodejs/node#63161 (v24.18.0) and fixed the ML-KEM expectations in nodejs/node#65966 (v24.22.0), so they now pass. The es-module/test-esm-wasm entry is a stale prefix: test.py matches entries as substrings of the path, so it was hiding 13 split files that pass. A few entries are dropped because the tests now skip themselves. parallel/test-cluster-primary-error, parallel/test-cluster-primary-kill, parallel/test-diagnostics-channel-memory-leak and parallel/test-worker-resource-limits move to the flaky list instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M * test: keep two node tests disabled that crash on the testing build test-vm-compile-function-lineoffset hits a V8 Smi::IsValid debug check and test-domain-error-types segfaults under --stress-compaction. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M --------- Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit bcc5c51) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M
3 of 4 tasks
dsanders11
approved these changes
Oct 19, 2026
jkleinsc
approved these changes
Oct 19, 2026
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by David Babenko-Sanders · Slack thread
Description of Change
Manually backport #55071. See that PR for details.
The conflict was only in
script/node-disabled-tests.json, where this branch has three extra entries (parallel/test-node-output-v8-warning,parallel/test-process-get-builtin,parallel/test-tls-no-sslv23) that stay disabled; all 76 removals and the 4 flaky-list additions match main. Validated locally against the v44.9.0 linux-x64 release with the 44-x-y node patches applied to Node.js v24.22.0: all 124 re-enabled test files and the 4 tests moved to the flaky list passed in 3 of 3 runs.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M
Release Notes
Notes: none