This repository was archived by the owner on May 14, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on May 14, 2026. It is now read-only.
showcase samples should be part of golden tests #2470
Description
sample snippets here should be part of the golden testing for Showcase.
Steps to identify this:
rm -rf showcase/gapic-showcase/samples/
mvn clean install -DskipTests
cd showcase
then mvn compile -P update, expect the samples should be re-generated and added back.
But this samples folder is not re-generated
Activity
blakeli0 commentedon Mar 4, 2024
I think it worked before, could it be an issue caused by migrating Showcase to the hermetic build scrips? cc: @diegomarquezp @JoeWang1127
JoeWang1127 commentedon Mar 4, 2024
Probably because we didn't copy sample directory in https://github.com/googleapis/sdk-platform-java/blob/main/showcase/scripts/generate_components.sh
lqiu96 commentedon May 21, 2024
Keeping this a P2 issue. Seems to be due to a regression in the hermetic build scripts.
blakeli0 commentedon Aug 6, 2024
This was done in the early phase of hermetic build when we didn't have the image. We should migrate the showcase module to use hermetic build image now, with a dedicated generation_config.yaml.
diegomarquezp commentedon Jan 16, 2025
#3568 uses the docker image and generates samples
feat: generate showcase using docker image (googleapis#3568)
feat: generate showcase using docker image (#3568)