Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

DOS line-endings in @microsoft/botframework-cli/bin/run when installed with yarn #711

Open
Open
DOS line-endings in @microsoft/botframework-cli/bin/run when installed with yarn#711
Assignees
munozemilio
Labels
Area: SchemaThe issue is related to schemas (bot schemas, skill manifest, etc.)Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.backlogThe issue is out of scope for the current iteration but it will be evaluated in a future release.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.feature-requestA request for new functionality or an enhancement to an existing one.

Description

@livviest
liv (livviest)
opened on Apr 15, 2020

Versions

What CLI version are you using.
@microsoft/botframework-cli/4.8.0 linux-x64 node-v13.12.0
What Nodejs version are you using
v13.12.0
What command-line interpreters are you using
bash
What OS are you using
Manjaro Linux 4.19.114-1

Describe the bug

Installing bf in a *nix environment using yarn@v1.22.4 results in the following error
/usr/bin/env: ‘node\r’: No such file or directory

To Reproduce

Steps to reproduce the behavior:

  1. Install on Linux 4.19 using yarn global add @microsoft/botframework-cli
  2. Run bf

Expected behavior

I expected it to run without the error detailed above

Workaround

Install using npm@v6.14.4 instead, otherwise if installing with yarn@v1.22.4 try the following:

  1. Install dos2unix
  2. Locate @microsoft/botframework-cli/bin/run
    • This will vary depending on how bf was installed
    • Mine was located at ~/.config/yarn/global/node_modules/@microsoft/botframework-cli/bin/run
  3. Use dos2unix on run

Note: dos2unix will not work on symbolically linked files so be sure to locate the actual file

[bug]

Activity

  1. ImageAxel Suárez (axelsrz)
    assigned
    Emilio Munoz (munozemilio)
    on Apr 16, 2020

  2. axelsrz commented on Apr 16, 2020

    @axelsrz
    Axel Suárez (axelsrz)
    on Apr 16, 2020
    Member

    Hey Emilio Munoz (@munozemilio) could you take a look at this?

  3. munozemilio commented on Apr 17, 2020

    @munozemilio
    Emilio Munoz (munozemilio)
    on Apr 17, 2020
    Contributor

    Hello @ChrisRenfrow. I just installed and ran the cli in a clean vm and the command worked just fine.
    Screen Shot 2020-04-16 at 10 32 39 PM

  4. ImageEmilio Munoz (munozemilio)
    added
    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.
    customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.
    customer-reportedIssue is created by anyone that is not a collaborator in the repository.
    on Apr 17, 2020
  5. Imageliv (livviest)
    changed the title [-]DOS line-endings in `@microsoft/botframework-cli/bin/run`[/-] [+]DOS line-endings in `@microsoft/botframework-cli/bin/run` when installed with yarn[/+] on Apr 17, 2020

  6. livviest commented on Apr 17, 2020

    @livviest
    liv (livviest)
    on Apr 17, 2020
    Author

    Emilio Munoz (@munozemilio) Upon closer inspection it looks like it has something to do with installing using yarn rather than npm. I've included more details above.

  7. munozemilio commented on Apr 17, 2020

    @munozemilio
    Emilio Munoz (munozemilio)
    on Apr 17, 2020
    Contributor

    Got it. I will flag this as an enhancement. We have no documentation around yarn so that be something we will have to add/test and flag as supported. Thanks for reporting this @ChrisRenfrow

  8. ImageEmilio Munoz (munozemilio)
    added
    R10Release 10 - August 17th, 2020
    enhancement
    on Apr 17, 2020
  9. ImageEmilio Munoz (munozemilio)
    removed
    R10Release 10 - August 17th, 2020
    on Jun 23, 2020
  10. ImageSrinaath Ravichandran (srinaath)
    assigned
    Eyal (scheyal)
    and unassigned
    Emilio Munoz (munozemilio)
    on Jun 25, 2020

  11. scheyal commented on Jun 25, 2020

    @scheyal
    Eyal (scheyal)
    on Jun 25, 2020

    Investigation: Issue is indeed 0a0d in first line
    #!/usr/bin/env node

  12. 4 remaining items

  13. ImageEyal (scheyal)
    assigned
    Emilio Munoz (munozemilio)
    on Jul 13, 2020

  14. scheyal commented on Jul 13, 2020

    @scheyal
    Eyal (scheyal)
    on Jul 13, 2020
  15. ImageEyal (scheyal)
    removed their assignment
    on Jul 21, 2020
  16. ImageEyal (scheyal)
    added
    R11
    and removed
    R10Release 10 - August 17th, 2020
    on Jul 21, 2020
  17. ImageGabo Gilabert (gabog)
    added this to the R11 milestone on Sep 10, 2020
  18. ImageGabo Gilabert (gabog)
    added
    feature-requestA request for new functionality or an enhancement to an existing one.
    and removed
    R11
    enhancement
    on Sep 10, 2020
  19. ImageTien Suwandy (tsuwandy)
    added
    Area: SchemaThe issue is related to schemas (bot schemas, skill manifest, etc.)
    R11
    on Sep 14, 2020
  20. ImageEmilio Munoz (munozemilio)
    removed
    R11
    on Oct 14, 2020
  21. ImageEmilio Munoz (munozemilio)
    removed this from the R11 milestone on Oct 14, 2020
  22. ImageEmilio Munoz (munozemilio)
    added
    backlogThe issue is out of scope for the current iteration but it will be evaluated in a future release.
    on Oct 19, 2020
  23. ImageChris McConnell (chrimc62)
    added
    ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.
    on Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area: SchemaThe issue is related to schemas (bot schemas, skill manifest, etc.)Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.ExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.backlogThe issue is out of scope for the current iteration but it will be evaluated in a future release.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.feature-requestA request for new functionality or an enhancement to an existing one.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions