Repository navigation
Should be able to select email associated with merge commit #5326
Description
In github UX you can select an e-mail associated with your merge commit.
Unfortunately using the UX in VSCode I'm never presented with that dropdown (nor is it remembering my default for the repo as I set it on github) therefore I just merged something with the wrong e-mail for this organization.
Activity
alexr00 commentedon Jan 31, 2024
As far as I can tell, there's no way to get all your email addresses with GitHub's API (graphQL or REST). To prevent accidentally using the wrong email though, we should show which email will be used in the UI.
alexr00 commentedon Jan 31, 2024
Hylke Bons (@hbons) here's what I'm adding:
alexr00 commentedon Jan 31, 2024
Maybe it makes sense to allow free-form input for the email so that it can be set to something else if the default email from GitHub isn't what you want...
Show email that will be associated with the commit
alexr00 commentedon Jan 31, 2024
Actually, this seems to allow it: https://docs.github.com/en/rest/users/emails?apiVersion=2022-11-28#list-email-addresses-for-the-authenticated-user
alexr00 commentedon Feb 1, 2024
Using the same input-box style button as in the "Create" view to show a quick pick to chose an email:
1 remaining item
Show email that will be associated with the commit (#5703)
rzhao271 commentedon Feb 21, 2024
The UI glitches out for me for both Merge and Squash + Merge. I'm assuming there is a single option and it is my noreply email.
Account for undefined user email
alexr00 commentedon Feb 22, 2024
With #5777, if there is no default email then the "Commit will be associated with" will not show at all.
Account for undefined user email (#5777)
alexr00 commentedon Feb 22, 2024
Fix is now available in pre-release.
rzhao271 commentedon Feb 22, 2024
I have verified the no email case.